F/debugger cli delegated to python #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function log_template_elem_free_list() only freed the last GList wrapper in the linked list. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Instead of using a fixed size array, use a dynamically allocated one. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This makes it easier to discover commands available at the debugger prompt, as you only need to press enter to get the list. Also, it tests the debugger_free() call better. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
In some cases the expr_node member is not set for a LogPipe, handle that case gracefully. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This patch makes it possible to register a fetch_command() function that reads the command into the debugger. This can be used to implement a different front-end for the debugger. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This function didn't exist previously, implement that so that Debugger instances can be freed without leaks. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Make it possible to free Debugger instances without leaks. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
bazsi
force-pushed
the
f/debugger-cli-delegated-to-python
branch
from
81ac83e
to
a0b3648
Compare
|
This should now work properly under travis as well and is now (again) considered ready for merging. Let's hope that travis agrees. |
lbudai
added a commit
that referenced
this pull request
Mar 27, 2015
F/debugger cli delegated to python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains some improvements to the code in lib/debugger and also makes it possible to change the function that the debugger console uses to fetch a command.
This functionality is in turn used to delegate the fetch_command() to a Python function.
A subsequent branch (WIP is available in f/debugger-cli-in-python) is using this functionality to implement tab-completion for the debugger language, with proper support for template strings.
Please merge.