pdbtool: If a test message has no program attribute, warn when verbose

[algernon]

When encountering a test message that has no program attribute, warn
about it when verbose mode is on. The rationale for only doing it in
verbose mode is that there are valid reasons for having no program
attribute for a test (to temporarily disable it, for example), and we
don't want to needlessly spew a lot of warnings at the user.

Reported-by: Fabien Wernli bugzilla.balabit@faxm0dem.org
Signed-off-by: Gergely Nagy algernon@balabit.hu

[bazsi]

Hi,

I have merged my alternate implementation, that adds further error checks to pdbtool and disables on-console timestamp printing for pdbtool and similar tools.

I'll keep this PR open as long as we've cleared up the case with 3.4 and 3.5

Thanks.

[algernon]

I will merge the updated versions for 3.4 and 3.5 later today, so they'll be part of the next release (in a few months). Thanks!

[bazsi]

Do you need this PR to track the 3.4/3.5 stuff? it's bothering me a little, but not too much.

I just want to avoid cluttering the PR list with unattended items. It is already scheduled to the "postponed items" but still...

if it helps you in any way it should stay.

[algernon]

Yes, please keep this open for a bit longer. I have so much stuff going on that I need a reminder.

[algernon]

Finally merged the correct patch to 3.4 and 3.5 master, so closing this one.