completerlang: quick fix for PLY-3.6 #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local variable 'state' is not in frame 1 anymore, it is in frame 2 in PLY-3.6 (there is a callback which calls our function this is the reason why the state variable is in frame 2). Note that this is an ugly-ugly hack :-) We have to eliminate this sitation somehow. Signed-off-by: Laszlo Budai <Laszlo.Budai@balabit.com>
|
I agree it is an ugly hack. The problem is that ply fails to publish this value to our callback, but upstream seems to be responsive so we might get a patch in that sets an attribute in the parser. However this hack is needed until that propagates to distros. I think this is ok for now. |
lbudai
added a commit
that referenced
this pull request
May 12, 2015
completerlang: quick fix for PLY-3.6
|
I understand the reason behind the patch (and know you wouldn't have wrote that code if there would be better solution) :-) patch ply : 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local variable 'state' is not in frame 1 anymore, it is in frame 2 in
PLY-3.6 (there is a callback which calls our function this is the reason why
the state variable is in frame 2).
Note that this is an ugly-ugly hack :-)
We have to eliminate this sitation somehow.
Signed-off-by: Laszlo Budai Laszlo.Budai@balabit.com