Makefile: Fix make dist in certain edge cases #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way internal modules were built, if both mongodb and libmongo-client was disabled, make dist failed. When amqp was explicitly disabled, make dist failed. The reason being, we use a dummy.c to trigger building the bundled libraries, but the dummy.c files were not created if mongodb/amqp were disabled. Now we create them anyway, just don't recurse into the directory when the module is disabled. Signed-off-by: Gergely Nagy <algernon@balabit.hu>
bazsi
added a commit
that referenced
this pull request
Jan 22, 2014
Makefile: Fix make dist in certain edge cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way internal modules were built, if both mongodb and
libmongo-client was disabled, make dist failed. When amqp was explicitly
disabled, make dist failed.
The reason being, we use a dummy.c to trigger building the bundled
libraries, but the dummy.c files were not created if mongodb/amqp were
disabled. Now we create them anyway, just don't recurse into the
directory when the module is disabled.
Signed-off-by: Gergely Nagy algernon@balabit.hu