make sure all path/dir variables are defined in a single location, by configure.ac #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable points to the root of the include directory. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This patch AC_DEFINEs PATH_SCLDIR, which earlier has only been an AC_SUBST variable. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Instead of reconstructing the proper paths from scl.conf, publish the actual configure.ac defined values, so those are really defined at a single location. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
|
So the segfault happens when the plugin.conf is found two times, once in the old and once in the new location both included due to the wildcard import. This should not happen in production but might if you install syslog-ng from source without uninstalling the old scl files first. |
Instead of open coding the path to the XML schema installation directory, do it in configure.ac. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
bazsi
changed the title
lbudai
added a commit
that referenced
this pull request
Feb 10, 2016
make sure all path/dir variables are defined in a single location, by configure.ac
|
@bazsi Thanks, just tested and it seems to have fixed my problems. I have now other problems, but most likely unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one should be a partial fix to #908 as it doesn't yet fix xsddir, but it does for scldir and config_includedir
NOTE: YOU CAN GET SEGFAULTS after merging this in a development environment: I've found a segfault in the lexer if two instances of scl/system/plugin.conf is included into the same config. I'm still diagnosing that issue, but I wanted to get this in.