fixing forms description for the docs and external account fixes

balanced · Mar 4, 2014 · 2d8bfa2 · 2d8bfa2
1 parent 013f37a
commit 2d8bfa2
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 7 deletions.
diff --git a/features/credit_cards.feature b/features/credit_cards.feature
@@ -247,7 +247,6 @@ Feature: Credit cards
         }
       """
 
-  @failing
   Scenario: Retrieving a card
     Given I have tokenized a card
     When  I make a GET request to /cards/:card_id

diff --git a/features/external_accounts.feature b/features/external_accounts.feature
@@ -13,7 +13,7 @@ Feature: External accounts
     Then I should get a 201 Created status code
     And the response is valid according to the "external_account_tokens" schema
 
-    When I GET /external_accounts/:external_account_id
+    When I GET "external_accounts.href" from the previous response
     Then I should get a 200 OK status code
     And the response is valid according to the "external_accounts" schema
 
@@ -31,7 +31,7 @@ Feature: External accounts
 
   Scenario: Unstore an external account
     Given I have tokenized an external account
-    When I DELETE to /external_accounts/:external_accounts_id
+    When I DELETE to /external_accounts/:external_account_id
     Then I should get a 204 OK status code
     And there should be no response body
 
@@ -46,7 +46,9 @@ Feature: External accounts
     Then I should get a 201 Created status code
     And the response is valid according to the "debits" schema
 
+  @failing
   Scenario: Add an external account to a customer
+    # the patch permission has an issue with external accounts
     Given I have created a customer
     And I have tokenized an external account
     When I make a PATCH request to the href "href" with the body:

diff --git a/features/rest/callbacks.feature b/features/rest/callbacks.feature
@@ -36,6 +36,23 @@ Feature: Callbacks
       { "category_code": "duplicate-webhook-url" }
       """
 
+  Scenario: Create a callback using GET method
+    When I POST to /callbacks with the JSON API body:
+    """
+    {
+      "url": "http://www.example.com/callback",
+      "method": "get"
+    }
+    """
+    Then I should get a 201 Created status code
+    And the response is valid according to the "callbacks" schema
+    And the fields on this callback match:
+    """
+    {
+      "method": "get"
+    }
+    """
+
   Scenario: List all callbacks
     You can only have one callback, but if you don't know the ID,
     getting the list makes sense. It'll just only have one.

diff --git a/features/rest/debits.feature b/features/rest/debits.feature
@@ -42,7 +42,11 @@ Feature: Debit a card or bank account
     When I POST to /customers/:customer_id/debits with the JSON API body:
     """
     {
-      "amount": 2000
+      "amount": 2000,
+      "meta": {
+        "product_id": "123123123"
+      },
+      "description": "Bob is giving me some $$$"
     }
     """
     Then I should get a 201 Created status code
@@ -53,7 +57,11 @@ Feature: Debit a card or bank account
       "amount": 2000,
       "links": {
         "customer": ":customer_id"
-      }
+      },
+      "meta": {
+        "product_id": "123123123"
+      },
+      "description": "Bob is giving me some $$$"
     }
     """
 

diff --git a/features/step_definitions/external_accounts.rb b/features/step_definitions/external_accounts.rb
@@ -1,7 +1,7 @@
 Given(/^I have an external account$/) do
   @client.post('/external_accounts', {
                  token: '123123',
-                 network: 'test'
+                 provider: 'test'
                })
   @external_account_id = @client['id']
   @client.add_hydrate :external_account_id, @external_account_id

diff --git a/fixtures/_models/callback.json b/fixtures/_models/callback.json
@@ -16,7 +16,11 @@
         },
         "method": {
             "type": "string",
-            "pattern": "post"
+            "enum": [
+                "post",
+                "put",
+                "get"
+            ]
         },
         "revision": {
             "type": "string",