New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Cukes #431
Introducing Cukes #431
Commits on Dec 13, 2013
-
Also, start over again with Cucumber, and import the fixture schemas from before.
-
"Tokenize a card without a secret" works.
There's a teeny bit of extra infrastructure to get a token. I built it by accident, but we'll need it eventually, so I just left it in.
Commits on Dec 18, 2013
-
Set up rake tasks to make running features easier
Three things here: 1. I'm going to translate features over, and mark them as failing when they are failing. I'll also tag them with gh-N to mark GitHub issue #N that they go along with. 2. `bin/rake cruise` has been set up to run for CI. Basically, it runs all the things that aren't failing, and makes sure they pass. Then, it runs all thet hings that are supposed to be failing, and makes sure they fail. If either of those are not true, it fails the build, and if they both pass, they pass. This way we know when something starts passing again, and to remove the failing tag. 3. `bin/rake focus` is added when developing new scenarios. You just tag the scenario you're working on with `@focus`, and then `bin/rake focus` will run just that one scenario.
-
New feature: creating API keys.
There was no existing schemas for the API key response, so I made one.
-
-
-
-
Refactor/reorganize steps for clarity.
It's important not to refactor steps _too_ much, but these were certainly http steps and not card steps.
-
-
-
-
-
Refactor schema error handling, reintroduce failure
We should handle these errors better, and now that we are, let's reintroduce the failing second half of the scenario. I'm actually not entirely sure that flunk-ing with the message is any different than just bubbling up the error, but at least it's a real assertion failure error, rather than a JSON API parsing error.
-
-
-
-
-
-
This was failing, but for the wrong reasons. Let's fail for the right ones.
-
Clean up some small formatting issues.
I missed these in my earlier cleanups.
-
-
-
-
-
-
-
I took @matthewfl's work on the client library and fixed it up a bit. There were some idiom issues, some conventions that we're followed, and a couple of OOP things that _really_ bugged me. I'm happy with this now, other than two things: we are doing OO terribly with this whole response thing, and we should also implement DELETE.
-
-
-
-
-
-
-
Thanks for setting me straight, @mjallday
-
-
-
-
-
-
-
We'll keep these CRUD ones here, and do more intersting cases in the main folder.
-
-
-
-
-
-
-
Commits on Dec 19, 2013
-
Add an alias for requests using different language
The phrase "I POST to /foo" and "Make a GET request to /foo" both sound 'correct.' So let's support both, depending on whichever sounds better.
-
-
Commits on Dec 20, 2013
-
-
Better error messages on status code failure.
Basically, "Got a 409, expected a 201" isn't actually very helpful. We can grab the error description out of the body and print it out, and it's way more helpful.
-
New feature: create a reversal.
This is probably the worst commit I've made in a while. I'm basically not happy with any real part of it. But it works. We use the url_template gem to handle url templating, but it isn't expanding variable names correctly, so I'm doing that myself. With gsub. Hopefully I can clean that up. Furthermore, we need to sort of store an 'environment' of mappings of ivars to the template names. Global-ish mutable state makes me very uneasy... @matthewfl, I want your opinion on how to not make this suck.
-
Issue #455 is tracking the failure.
Commits on Dec 21, 2013
-
New feature: failed reversal on bank account.
Issue #456 is tracking the failure.
-
-
-
make a distinction between having a card and a customer card.
We were doing it the wrong way before.
-
-
Commits on Dec 25, 2013
Commits on Dec 27, 2013
-
Add HTTP PATCH to tiny client.
We need this for increasingly more scenarios
-
This is needed for debugging when things go sideways.
-
Commits on Dec 28, 2013
-
New feature: refunds go to original funding source.
I made the last scenario mis-understanding the way that the YAML scenarios worked. Often, they have duplicate stuff with new names just to make sure that things work. That means I don't need to translate them 1-1, I have to figure out which thing is actually important and just do that.
-
New feature: create a failing refund
This is currently not working. #459 is tracking it.
-
-
New feature: debits to unverified bank accounts fail.
Note that this is different than the old spec, which was incorrect.
-
-
New feature: fail to debit a customer
I don't know why this is failing. #460 is tracking it.
Commits on Dec 31, 2013
-
New feature: default funding source.
This is failing due to the content-type issue
Commits on Jan 3, 2014
Commits on Jan 4, 2014
Commits on Jan 6, 2014
-
-
-
-
Passing: reverse a credit on a bank account.
I had the wrong fixture data, so it was creating a failed credit, rather than a succeeded one.
-
remove 'set the default funding source
In 1.1, only instruments can be credited, so a default funding source doesn't make sense. See #460
Commits on Jan 7, 2014
-
Moving forward on 'create an order'
There's still a failure, unsure which part is right or wrong.
-
progress on checking escrow on orders.
Same delivery address issue
-
Previously, @matthewfl had added some logging stuff, this is a bit heavier, but often useful.
-
Making some progress on 'checking escrow of order'
Erroring for the same reason the other Orders are.
-
Making progress on 'orders can't be credited more...
... than escrow balance.
-
-
I missed this one because the scenario fails before it hit this part. But it's pretty obvious it needs fixed.
-
Typo fix: should be an order not an error
The scenario failed before this, but I want to catch it now. Bady copy/paste on my part
-
-
Commits on Jan 8, 2014
-
Merge remote-tracking branch 'origin/cukes' into cukes
Conflicts: features/customers.feature
-
Commits on Jan 11, 2014
-
-
make some progress on crediting an unverified merchant.
#474 is tracking this particular failure.
Commits on Jan 13, 2014
Commits on Jan 23, 2014
-
-
making progress on 'existing buyer makes a purchase with an existing …
…card. Yet another #469 victim.
-
-
-
-
-
-
Making progress on 'AVS postal code is unused.
#438 will fix this.
-
-
-
Making progress on 'avs street match is null'
#438 will fix that.
-
-
Make some progress on retrieving card info
#480 is tracking this.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Jan 24, 2014
-
-
Fix up specs related to reversals.
Accidentally had two successes, now we have one and a fail.
-
-