Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev1 doesn't work with Ember.js #49

Closed
kleinsch opened this issue Oct 1, 2013 · 1 comment
Closed

Rev1 doesn't work with Ember.js #49

kleinsch opened this issue Oct 1, 2013 · 1 comment

Comments

@kleinsch
Copy link
Contributor

kleinsch commented Oct 1, 2013

In src/balanced.js line 226 and 315, you're not checking hasOwnProperty when iterating through object properties. Since Ember.js adds extensions to arrays, ec will be >0 for an empty array, causing all creates to fail.
@nodesocket
Copy link
Contributor

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kleinsch @nodesocket