Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isSecurityCodeValid in 1.1 #70

Closed
mjallday opened this issue Jan 21, 2014 · 4 comments · Fixed by #76
Closed

Rename isSecurityCodeValid in 1.1 #70

mjallday opened this issue Jan 21, 2014 · 4 comments · Fixed by #76
Labels
enhancement

Comments

@mjallday
Copy link
Contributor

@remear pointed out that the csc field has been renamed to card verification value (cvv) and as such we should change the method to isCardVerificationValueValid or isCVVValid
@remear
Copy link
Contributor

remear commented Jan 22, 2014

I prefer isCVVValid since it's less verbose.

@steveklabnik
Copy link

Three Vs in a row makes me cringe, but I guess it's not the worst thing.

@mjallday
Copy link
Contributor Author

Or we rename it to validateCVV the same as #71!

@steveklabnik
Copy link

Making the call: isCVVValid.

@remear remear mentioned this issue Jan 22, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename isSecurityCodeValid to isCVVValid remear/balanced-js
3 participants
@steveklabnik @remear @mjallday