Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename isSecurityCodeValid to isCVVValid #76

Merged
merged 2 commits into from
Jan 24, 2014

Conversation

remear
Copy link
Contributor

@remear remear commented Jan 22, 2014

Fixes #70

@mjallday
Copy link
Contributor

@remear i almost forgot that this is a breaking change. we should alias the old command to this until we have a chance to update any users of this feature and #75 too.

@matthewfl
Copy link
Contributor

this is just going out on rev1 right? so there should not be any real problems with this breaking change right?

@mjallday
Copy link
Contributor

The dashboard would break until we deployed a new version since it's pegged at the minor version, not the build.

@matthewfl
Copy link
Contributor

I think it would be easier then to just deploy both of these updates at the same, while that is not as "clean" I feel that is better then having soon to be dead code in balanced.js

mjallday added a commit that referenced this pull request Jan 24, 2014
Rename isSecurityCodeValid to isCVVValid
@mjallday mjallday merged commit b2a73b5 into balanced:rev1 Jan 24, 2014
@remear remear deleted the rename_is_security_code_valid branch January 24, 2014 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename isSecurityCodeValid in 1.1
3 participants