Refactor dynamodb saving, add secondary index #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some pool attributes are stored as strings in Javascript by should be numbers in DynamoDB so they can be compared with gt/lt and used as indexes. For example: totalShares and totalLiquidity. To do this we need to change the way DynamoDB inserts data to specify the exact type of each field and specify that these BigNumber fields should be numbers. - Remove a lot of console.logs and change them to debug logs instead.
timjrobinson
force-pushed
the
refactor-dynamodb-saving
branch
from
64bfab2
to
283f3ca
Compare
timjrobinson
changed the title
…n't crash on undefined/null fields
garethfuller
approved these changes
Aug 2, 2022
Comment on lines
+62
to
+65
| case 'Number': | ||
| default: | ||
| unmarshalledItem[key] = Number(value.value) | ||
| break; |
There was a problem hiding this comment.
Should the Number case be handled here and why is there his break statement at the bottom?
There was a problem hiding this comment.
Number just falls through to the default. Don't need the break at the bottom I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability for the GraphQL endpoint to filter by pools that have > n
totalSharesand to be able to sort bytotalLiquidityand possibly other things in the future. The problem is these are stored as strings in DynamoDB so aren't query-able as numbers. I was previously just usingNumber()before saving but this only allows 16 significant digits and rounds larger numbers so we lose precision.This is a refactor to insert the data with types specified for every field so that we can have strings in JavaScript but numbers in the database (and we can easily specify the types for all fields in the future). It adds a schema which is equivalent to the graphQL schema and specifies fields that are BigNumbers or Numbers. Both are stored in DynamoDB as numbers, but BigNumbers are strings in Javascript and Numbers are Numbers.
This PR also adds a secondary index to the pools table of chainid + totalLiquidity so we can easily query for all pools on a chain sorted by totalLiquidity.