Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit proportional #402

Merged
merged 21 commits into from
Apr 13, 2023
Merged

Exit proportional #402

merged 21 commits into from
Apr 13, 2023

Conversation

brunoguerios
Copy link
Member

@brunoguerios brunoguerios commented Mar 30, 2023

Add proportional exit to exitGeneralised.

  • In case any single pool within the pool graph does not support proportional exit (e.g. ComposableStable pools v1 and v2) the code will fallback to the previous implementation of proportionally performing several single token exits.
  • Uses fix added by this PR on SOR

@brunoguerios brunoguerios self-assigned this Mar 30, 2023
Base automatically changed from relayer-v5 to develop March 31, 2023 12:52
@brunoguerios brunoguerios marked this pull request as ready for review April 6, 2023 17:44
@brunoguerios brunoguerios changed the title Exit proportional (WIP) Exit proportional Apr 6, 2023
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brunoguerios brunoguerios merged commit 9c418e3 into develop Apr 13, 2023
@brunoguerios brunoguerios deleted the exit-proportional branch April 13, 2023 16:39
@johngrantuk johngrantuk mentioned this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants