Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement swap fees #99

Closed
Tracked by #146
jubeira opened this issue Sep 25, 2023 · 0 comments · Fixed by #120
Closed
Tracked by #146

Implement swap fees #99

jubeira opened this issue Sep 25, 2023 · 0 comments · Fixed by #120
Assignees
Labels
ecosystem-feature Feature to track on ecosystem project board

Comments

@jubeira
Copy link
Contributor

jubeira commented Sep 25, 2023

We'll go with a straightforward approach: take a fee in the tokens, on every swap.
We'll not accrue debt between joins / exits nor pay in BPT.

The swap fee should not imbalance the pools at any time; it should just be accounted separately.

We can start by transferring the fees elsewhere and measure the gas costs; warm storage access should make this cheaper than what it was by V2 launch. If needed, we can optimize in a second iteration.

@jubeira jubeira mentioned this issue Oct 20, 2023
11 tasks
@danielmkm danielmkm added the ecosystem-feature Feature to track on ecosystem project board label Nov 2, 2023
@marcusblabs marcusblabs mentioned this issue Nov 9, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem-feature Feature to track on ecosystem project board
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants