[FEAT] Bumps to web3 v6, adds linters, adds tests (pending upstream merge) #55
Conversation
| # checkout submodules | ||
| git submodule update --init --recursive |
There was a problem hiding this comment.
Not in the docs atm, might need to add the compile step too
| stringError = str('{}'.format(error)); | ||
| if "BAL#" in stringError: |
There was a problem hiding this comment.
I am wondering if this should be a submodule as well?
There was a problem hiding this comment.
There's some history around this -- it used to be a standalone package, was briefly a submodule, then was directly thrown into the package when the previous maintainer said they had no plans to make any future updates. It seemed safer to just move it into balpy to have the freedom to update as needed.
That being said, I am not aware of anyone using it, and the packages do have some errors in them. I've had someone find some notable issues in the stable math library, and the way that the "pools" themselves are structured is incorrect.
At this point, it might just make sense to remove them entirely, at least for now. It probably doesn't sense to move these files forward knowing that they have accuracy/implementation issues
| requests="2.25.1" | ||
| eth-abi="2.1.1" | ||
| gql="2.0.0" | ||
| multicaller=">=0.0.0a10" |
There was a problem hiding this comment.
samples/batchSwaps/sorSwapSample.py
Outdated
| if not tokens: | ||
| raise ValueError("No tokens provided in swap") |
There was a problem hiding this comment.
This is when the swap is not found in the router
| test: | ||
| poetry run pytest tests | ||
|
|
||
| all: fmt lint test |
There was a problem hiding this comment.
consistent formatting and linting
| def test_get_pool_ids(): | ||
| get_pool_ids(TEST_NETWORK) | ||
|
|
||
|
|
||
| def test_get_pools(): | ||
| get_pools(TEST_NETWORK) |
8ball030
changed the title
8ball030
changed the title
| gql=">=2.0.0" | ||
| jstyleson=">=0.0.2" | ||
| web3="~6" | ||
| multicaller = {path = "../multicaller"} |
[feat] ensured commit matches
This pr is to (Hopefully) bump balpy to web3.py > v5
There are a number of dependants which would need to be merged and released;
gerrrg/multicaller#1
I am very sorry about the size of this pr i got a little carried away.
However, it does accomplish few things and fixes a few bugs caught by the now introduced linters.
Features.
-> formatters to fix the incostent tabs and spaces issues, sort imports and format with black.
-> linters: -> autopep8
-> test suite: demonstrates functionality of the subgraph queries to allow for tests.
-> dev group for dependencies.
Probably a bit too aggressive i again apologies.