Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dune references to docs #72

Merged
merged 3 commits into from
Jun 6, 2024
Merged

add dune references to docs #72

merged 3 commits into from
Jun 6, 2024

Conversation

viniabussafi
Copy link
Member

Hey, @mkflow27!
I thought about adding dedicated dune dashboard and spells sections to the docs, given that I feel it's hard for internal and external users to gather this data on their own and we want to empower user autonomy as much as possible.
I'm open to any feedback regarding formatting and wording, hoping that it can blend in just fine with the great work you've been doing

Copy link

vercel bot commented May 9, 2024

@viniabussafi is attempting to deploy a commit to the Balancer Team on Vercel.

To accomplish this, @viniabussafi needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Copy link

vercel bot commented May 14, 2024

An owner of the Balancer Team on Vercel accepted @viniabussafi's request to join.

@viniabussafi's commit is now being deployed.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 8:01am

@viniabussafi
Copy link
Member Author

thanks, @mkflow27! ready to merge whenever you want

Copy link
Contributor

@Xeonus Xeonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now! Great work


## 1, 7 and 30 day volume on Balancer

```dunesql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viniabussafi dunesql is not supported in the code highlighting package we use. Might be worth to switch all code blocks to sql - like this we get proper syntax highlighting out of the box

@viniabussafi viniabussafi merged commit d172cf0 into v3-outline Jun 6, 2024
2 checks passed
@viniabussafi viniabussafi deleted the dune branch June 6, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants