Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Sanctions check via Balancer API #2031

Merged
merged 6 commits into from
Jul 1, 2022

Conversation

timjrobinson
Copy link
Contributor

@timjrobinson timjrobinson commented Jun 30, 2022

Description

Re-add the sanctions check (removed in: #2028), performing it using a Lambda running on the Balancer API instead.

PR to add the Lambda API endpoint: balancer/balancer-api#22

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Perform same tests as in #2017. Ensure that normal wallets connect fine and sanctioned wallets are blocked

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 2 reviews (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@vercel
Copy link

vercel bot commented Jun 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
arbitrum 🔄 Building (Inspect) Jul 1, 2022 at 6:55AM (UTC)
beta-app ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 6:55AM (UTC)
beta-arbitrum ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 6:55AM (UTC)
beta-goerli ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 6:55AM (UTC)
beta-kovan ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 6:55AM (UTC)
beta-polygon ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 6:55AM (UTC)
polygon 🔄 Building (Inspect) Jul 1, 2022 at 6:55AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
app ⬜️ Ignored (Inspect) Jul 1, 2022 at 6:55AM (UTC)
goerli ⬜️ Ignored (Inspect) Jul 1, 2022 at 6:55AM (UTC)
kovan ⬜️ Ignored (Inspect) Jul 1, 2022 at 6:55AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants