-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: Sanctions check via Balancer API #2031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timjrobinson
requested review from
pkattera,
mikemcdonald,
mrchickenburger and
alter-eggo
June 30, 2022 03:17
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alter-eggo
approved these changes
Jul 1, 2022
mrchickenburger
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-add the sanctions check (removed in: #2028), performing it using a Lambda running on the Balancer API instead.
PR to add the Lambda API endpoint: balancer/balancer-api#22
Type of change
How should this be tested?
Perform same tests as in #2017. Ensure that normal wallets connect fine and sanctioned wallets are blocked
Checklist:
master
if hotfix,develop
if not