New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[volspotconnect-futurdev] adding ReplayGain Support #119
Comments
Hi! |
I'm compiling now a version of librespot with ReplayGain... It fails... Retry tomorrow.. |
I think people should have a choice so a switch would be nice.
cheers!
2018-01-15 21:23 GMT+01:00 balbuze <notifications@github.com>:
… I'm compiling now a version of librespot with ReplayGain... It fails...
Retry tomorrow..
But do you think I should add a switch in the webUI to enable/disable it ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV69TaHKyhPTyjPpQhwngpEldGrpbcEHks5tK7O2gaJpZM4Rbdrr>
.
|
ok I have a working version for x64... |
Wow, that's great. cheers! |
I've been using it today, and it sounds very nice. play the song: Push pause try to resume Jan 17 20:33:32 woonkamer volumio[10197]: thread 'main' panicked at 'called do you know how to run with backtrace? |
Hi, |
I found something maybe wrong in the code... I'm recompiling librespot to see if better... |
outch ! After a long fight my network problem is solved... So I uploaded a "regular" version of volspotconnect2 including all last changes/improvements. Hope it will be fine.... |
did you manage to get the stop error out of it, or is it still present? I've also encountered some issues with the implementation it seems to clip with very quiet tracks. happy listening! |
Yes it seems to be fixed.by the code I modified.. I'm using it for several days and didn't experienced any problems.... |
hmmm I've uninstalled rebooted and installed, but I encounter the same
problem,
librespot panic's when pausing the music.
are you sure you've uploaded the right binairy?
2018-01-24 22:00 GMT+01:00 balbuze <notifications@github.com>:
… Yes it seems to be fixed.by the code I modified.. I'm using it for
several days and didn't experienced any problems....
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV69TaMGEv3_1ymzQz4CpqSBopEnqk50ks5tN5oDgaJpZM4Rbdrr>
.
|
ah you didn't change install.sh it is still downloading from
futeredev....thus the old librespot file is downloaded :)
2018-01-24 22:09 GMT+01:00 Dennis van Paassen <dvpaassen@gmail.com>:
… hmmm I've uninstalled rebooted and installed, but I encounter the same
problem,
librespot panic's when pausing the music.
are you sure you've uploaded the right binairy?
2018-01-24 22:00 GMT+01:00 balbuze ***@***.***>:
> Yes it seems to be fixed.by the code I modified.. I'm using it for
> several days and didn't experienced any problems....
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#119 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AV69TaMGEv3_1ymzQz4CpqSBopEnqk50ks5tN5oDgaJpZM4Rbdrr>
> .
>
|
Do you use volspotconnect2, not volspotconnect-futurdev? |
Or I made a mistake? Can't check now.. |
yeah you made a mistake in the install script, the new binairy works perfectly, thank you again!!! you know people get paid to do this sort of things :) good night |
Damn! |
done! |
Thank you!
BTW did you notice the movement on the librespot front?
Seems like finally all forks Will come together..
Op 25 jan. 2018 6:50 p.m. schreef "balbuze" <notifications@github.com>:
… done!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#119 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV69TajjCXc49Jyjckp_Gg97LCYh35tKks5tOL7IgaJpZM4Rbdrr>
.
|
Closing this, thank you for your work... cheers! |
Hi Balbuze,
did you notice Herrernst implemented ReplayGain support.
https://github.com/herrernst/librespot/tree/volume-normalization/src
This would truly be an addition to volspotconnect2
The text was updated successfully, but these errors were encountered: