Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volspotconnect2 - Player stops when finding an unplayable song #266

Closed
pachulo opened this issue May 1, 2020 · 9 comments
Closed

Volspotconnect2 - Player stops when finding an unplayable song #266

pachulo opened this issue May 1, 2020 · 9 comments

Comments

@pachulo
Copy link

pachulo commented May 1, 2020

I think this was not happening before the update to 1.0.x, but anyway: I just found out that when connected to Volumio, if I “SHUFFLE PLAY“ a playlist that contains unplayable songs some of those might get queued and, as soon as Volumio tries to reproduce one, instead of skipping it, stops playing.

I don't really know where the problem is, because when I'm listening on in my phone I never get unplayable songs queued...I guess because the “Show unplayable songs” setting is disabled, but I thought that it will also apply to Volumio Spotify Connect plugin...

@pachulo pachulo changed the title Player stops when trying to play an unplayable song Volspotconnect2 - Player stops when trying to play an unplayable song May 1, 2020
@pachulo pachulo changed the title Volspotconnect2 - Player stops when trying to play an unplayable song Volspotconnect2 - Player stops when finding an unplayable song May 1, 2020
@ashthespy
Copy link

Could you share such a playlist?

@pachulo
Copy link
Author

pachulo commented May 1, 2020

Yeah, sorry; here's one example:

@pachulo
Copy link
Author

pachulo commented May 8, 2020

were you able to reproduce this @ashthespy ?
Thanks!

@ashthespy
Copy link

ashthespy commented May 8, 2020

@pachulo sorry, this slipped under my radar, will try looking at it over the weekend!

EDIT: Had a quick look, looks like with the new gapless playback changes, unplayable tracks are just stopped, instead of skipped.

[Vollibrespot] : Event: PlaybackLoading { track_id: SpotifyId { id: 221688197964708279733893794639650733090, audio_type: Track } }
[Vollibrespot] : Loading <Dancing With Myself - 2001 Digital Remaster> with Spotify URI <spotify:track:54HWkXBa3O7jH4vletYhc6>
[Vollibrespot] : <spotify:track:54HWkXBa3O7jH4vletYhc6> is not available
[Vollibrespot] : The player has stopped unexpectedly.

Fixed it upstream, will add it into the next build :-)

@ashthespy
Copy link

@pachulo Fixed in Vollibrespot v0.2.1

@pachulo
Copy link
Author

pachulo commented May 25, 2020

Out of curiosity: when will this show up @ashthespy ?

Thanks!

@ashthespy
Copy link

You can already install it via ssh from this repository, not sure when it will be made available in the plugin repo..

@ashthespy
Copy link

Just noticed @balbuze merged v1.0.3 to the official plugin repo as well..

@pachulo
Copy link
Author

pachulo commented May 25, 2020

Tested and working! Thanks a lot!

@pachulo pachulo closed this as completed May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants