Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Remove "embeds" header from model template #81

Closed
wants to merge 1 commit into from

Conversation

brianpeiris
Copy link

I'm new to sails, but as far as I can tell, the concept of "embeds" is an old one that is no longer mentioned in the current documentation, so I'd suggest removing it from the model generator template.

I'm new to sails, but as far as I can tell, the concept of "embeds" is an old one that is no longer mentioned in the current documentation, so I'd suggest removing it from the model generator template.
@rachaelshaw
Copy link
Member

Hi @brianpeiris, we're planning on keeping this in the template, as we actually end up adding things under that heading in a lot of projects– if you want to see the kind of thing that might be included in that section of the file, here's an example.

Thanks for pointing out we didn't have this concept documented anywhere; if you can think of a place in the documentation where it might make sense to include that information, I'm open to suggestions!

@brianpeiris
Copy link
Author

brianpeiris commented Oct 28, 2020

Ah, gotcha. Thanks for the reply.
It's still unclear to me what an "embed" is and how it differs from a regular attribute. I suppose this might be a section under the existing Attributes documentation, unless Embeds are unique and important enough a concept to be documented separately under the Models and ORM docs.

@brianpeiris brianpeiris deleted the patch-1 branch October 28, 2020 22:42
@brianpeiris
Copy link
Author

Yeah, my google-fu is failing me because I can't find any references to the concept of "embeds" in relation to sails. Presumably if this header is important, the concept is worth calling out in the docs. At least a definition would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants