Skip to content

Commit

Permalink
Update socket.io-client to latest version
Browse files Browse the repository at this point in the history
Also update Grunt task to reflect the new location of `socket.io.js` in the `socket.io-client` package
  • Loading branch information
sgress454 committed Dec 9, 2016
1 parent b13e1da commit 1250230
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ module.exports = function(grunt) {

uglify: {
main: {
src: ['./node_modules/socket.io-client/socket.io.js'],
src: ['./node_modules/socket.io-client/dist/socket.io.js'],
dest: '<%= PATHS.socketioClient %>'
}
},
Expand Down
7 changes: 5 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"request": "2.74.0",
"sails": "^1.0.0-16",
"sails-hook-sockets": "^1.2.3",
"socket.io-client": "1.4.5"
"socket.io-client": "1.7.0"

This comment has been minimized.

Copy link
@mikermcneil

mikermcneil Dec 9, 2016

Member

should be 1.7.1 right?

},
"scripts": {
"test": "node ./node_modules/mocha/bin/mocha -b --reporter spec --timeout 10000",
Expand All @@ -47,5 +47,8 @@
"bugs": {
"url": "https://github.com/balderdashy/sails.io.js/issues"
},
"homepage": "https://github.com/balderdashy/sails.io.js"
"homepage": "https://github.com/balderdashy/sails.io.js",
"dependencies": {
"socket.io-client": "1.7.1"

This comment has been minimized.

Copy link
@mikermcneil

mikermcneil Dec 9, 2016

Member

this shouldn't need to be a dep (only a devDep) since the distributable is built separately (regardless, it can't be both-- so I'm guessing this was a typo)

}
}

0 comments on commit 1250230

Please sign in to comment.