Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to express@3.16.0 and skipper@next #2070

Closed
leedm777 opened this issue Aug 6, 2014 · 3 comments
Closed

Upgrade to express@3.16.0 and skipper@next #2070

leedm777 opened this issue Aug 6, 2014 · 3 comments

Comments

@leedm777
Copy link
Contributor

leedm777 commented Aug 6, 2014

There are a couple of recently announced security vulnerabilities in qs:

This is addressed in express@3.16.0, and should be addressed in skipper once this issue has been fixed.

This is also a dependency for grunt-contrib-less and grunt-contrib-watch, but those modules shouldn't be processing user provided query strings, so it's hopefully not as urgent to get those dependencies updated.

@mikermcneil
Copy link
Member

@leedm777 re: grunt, both of those modules only run in development, so we should be good (in addition to the reasons you pointed out). We're using Express >=3.4.x in Sails core atm, so that should also be good. Re: connect in Skipper, that's resolved by sailshq/skipper@911e2bf and will be published momentarily as 0.5.3 on npm. We'll follow up shortly afterward with a patch release of Sails as well with a minimum dep on 0.5.3 of skipper.

Thank you!

mikermcneil added a commit that referenced this issue Aug 6, 2014
Kikobeats added a commit to sailorjs/sails that referenced this issue Aug 10, 2014
* sails:
  Update EVENTS.md
  Expanded roadmap.
  Update ROADMAP.md
  Update ROADMAP.md
  Update ROADMAP.md
  Added information about new Feature Request procedure.
  Better explanation of setting sails.config.models.migrate.
  0.10.3
  0.10.2
  Depend on skipper 0.5.3 re: balderdashy#2070
  0.10.2
  Added tests for router changes in balderdashy@42a0aaf
  Changed "prompt" dependency to use ~
  Fixed typo
  Add "migrate:alter" to test fixture so that it doesn't prompt.
  Don't use _ global in core hook since it can be turned off (Or do `var _ = require('lodash');`)
  Update index.js
  Proposal to fix sails www --prod
@leedm777
Copy link
Contributor Author

The express dependency is still set to express@3.4.3, so we still have a problem. The skipper update looks good, though.

@mikermcneil
Copy link
Member

thanks @leedm777 - merged #2291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants