Please upgrade minimist

[ebaynaud]

Sails version (sails): 1.2.3

---

A minimist vulnerability was found, is it possible to upgrade minimist to the latest version?

[sailsbot]

@ebaynaud Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

• look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
• tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
• make sure you've provided clear instructions on how to reproduce the bug from a clean install.
• double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
• read the code of conduct.
• if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[mikermcneil]

@ebaynaud minimist is a library we use for parsing command-line options, so I don't think this vulnerability has a material impact. That said we want to keep things clean when Sails is installed, so thank you for bringing this to our attention!

What changed in minimist between 0.0.10 and 1.2.5?

[ebaynaud]

No changelog, no release notes, no breaking changes in readme.
Browsing commits seems to show incremental changes with a v1 as soon as the maintainer considered it to be stable.
Your tests are still passing so I guess this is not risky to upgrade.

[rachaelshaw]

Tested out my local sails with upgraded minimist, to make sure it was properly parsing command-line arguments:

• generated new app with --no-frontend
• generated new app with --caviar --fast
• lifted app with --redis

Everything's looking good 👍