Fix crash when using sessionless requests over WebSockets. #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When disabling sessions for individual requests, it's done by deleting the session field from the request. (See balderdashy#841). Unfortunately, the REST-over-WebSocket code assumed that the session was always there. This patch checks for the existence of req.session before calling req.session.save.
|
bump |
|
@sgress454 That detail doesn't really matter. You get the same crash, whether you delete or set it to |
|
Gotcha, makes sense now that I look at it. Thanks. |
sgress454
added a commit
that referenced
this pull request
Sep 26, 2014
Fix crash when using sessionless requests over WebSockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling sessions for individual requests, it's done by deleting
the session field from the request. (See
#841).
Unfortunately, the REST-over-WebSocket code assumed that the session was
always there. This patch checks for the existence of req.session before
calling req.session.save.