Before adding a userhook to be loaded, check that it was not marked as 'not' to load via config

[luislobo]

It fixes https://github.com/balderdashy/sails-hook-sockets/issues/16, where the sails-hook-sockets is disabled via config, but since it is a module, it is being loaded via the userhook method

[sgress454]

Hi @luislobo -- thanks for tracking this down. I think what we need to do is patch the version in the stable branch with the fix that's already there on master.

[luislobo]

well, yes, do you want me to just patch it? I mean, I generated the PR already... Sorry if I don't get your idea 😁

[luislobo]

Oh, I see what you mean, put both conditions on the same line... right?

[luislobo]

Well, I've checked and that fix actually is enough! I've compared both sails.config.hooks[hookName] and sails.hooks[hookName] and both contain the same value when setting sockets : false.
I think that then, this PR is not necessary.
We could change it to if (sails.config.hooks[hookName] === false || sails.hooks[hookName] === false) { to be very specific...
I've tested a new app using the current master branch and it does not fail.

[sgress454]

@luislobo Sorry if I wasn't clear. This problem is already fixed on master; no patch is necessary. The issue balderdashy/sails-hook-sockets#16 is happening on the current stable version of Sails (v0.11.x), which can be patched by making a PR to the stable branch. It would be nice to have 0.11.x fixed as well, even though we're about to release 0.12.

[luislobo]

New PR here: #3550 for current stable v0.11.x