Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixes #7201] Bump up prompt to 1.2.1 #7202

Merged
merged 1 commit into from Jan 10, 2022
Merged

[fixes #7201] Bump up prompt to 1.2.1 #7202

merged 1 commit into from Jan 10, 2022

Conversation

dhwaneetbhatt
Copy link
Contributor

This is done to fix the rogue colors package. Prompt@1.2.1 pins colors@1.4.0.

Issue: #7201

This is done to fix the rogue colors package. Prompt@1.2.1 pins colors@1.4.0.
@sailsbot
Copy link

Hi @dhwaneetbhatt! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

@dhwaneetbhatt dhwaneetbhatt changed the title Update version of prompt to 1.2.1 Fixes #7201 Jan 10, 2022
@sailsbot
Copy link

Hi @dhwaneetbhatt! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

@dhwaneetbhatt
Copy link
Contributor Author

@eashaw Requesting you to review this with priority as this breaks existing Sails versions for all customers. Thank you.

@dhwaneetbhatt dhwaneetbhatt changed the title Fixes #7201 [fixes #7201] Bump up prompt to 1.2.1 Jan 10, 2022
@sailsbot
Copy link

Thanks for submitting this pull request, @dhwaneetbhatt! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

  • discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
  • ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
  • if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@mikermcneil mikermcneil merged commit 023319e into balderdashy:master Jan 10, 2022
@mikermcneil
Copy link
Member

@dhwaneetblatt We'll publish ASAP. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants