Fix the error when file size exceeds maxBytes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an important fix, I hope the skipper team consider your PR as soon as possible. In the meantime I will use directly your fixes. |
|
Hi @mikermcneil @sgress454 what's the status of this one? |
|
Could you please fix the upload issues. It's a blocker in my project. |
|
working on it today |
mikermcneil
added a commit
that referenced
this pull request
Jan 23, 2015
Fix the error when file size exceeds maxBytes
|
@andyhu thank you! |
|
@mikermcneil I tried today and could not crash the process. For me it looks okay. Will still have an eye on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5