Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass headers to knox-mpu and auto detect content type if not set #6

Conversation

evert0n
Copy link
Contributor

@evert0n evert0n commented Aug 27, 2014

This is a prop to add support to automatically set the Content-Type and pass headers to knox-mpu

Related to issue #1 and http://stackoverflow.com/questions/25206528/how-to-add-acl-and-content-type-parameters-when-using-skipper-s3

Checked in knox-mpu and seems that there is no need for changes.

The mime package is also used with knox but only in a call to putFile.
https://github.com/LearnBoost/knox/blob/master/lib/client.js#L363

@meric426
Copy link

+1

@sgress454 sgress454 merged commit d9de584 into balderdashy:master Sep 24, 2014
@sgress454
Copy link
Member

It would be nice if we could have some tests for this skipper-adapter-tests, but that's a bit of a tall order at the moment. I tested locally and it looked good. Thanks!

@alexlenail
Copy link

This looks like it's fixed, but it's still confusing people largely because I don't think there's documentation for it. (e.g. #26 and even an alternate repo). I can fix the documentation if someone explains to me how exactly to use this fix. I think you need a headers member of the options object, and inside that header parameter you need to somehow specify 'public'. How does I?

@alexlenail
Copy link

Aha. Found this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants