Made it possible to overwrite the arguments we send to the 'node' and… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'lessc' commands from configuration. Also dropped support for PHP 5.5 and updated the README file.
… some documentation cleanup.
piotrkwiecinski
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
@hostep I'm sorry for the late reply. Had some personal issues.
I was able to do some testing and works well.
Options are passed as expected.
|
Thanks for testing! Give me a few days to wrap it up and tag a new version, I have some change in mind I still want to make. But I'm first dealing with the recent Magento security releases, that has a priority over this one ... :) |
|
Take your time. We have the same in the pipeline. |
…on't potentially break other people's custom preferences on this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… 'lessc' commands from configuration. Also updated the README file.