This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Code Quality Improvements #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsomoza
force-pushed
the
code-quality
branch
4 times, most recently
from
78361aa
to
c1bbf6f
Compare
Closed
gsomoza
force-pushed
the
code-quality
branch
9 times, most recently
from
83c6c21
to
9085a50
Compare
- Made MigrationBus class final and made it implement MigrationBusInterface - Changed AbstractTimeline signature to use MigrationBusInterface
- Version (base) will have the id and status only, plus a withMigration() function that will return a new instance of the same version data but with the specified migration and with a new class type of "LinkedVersion". - LinkedVersion (inherits from Version) will indicate a version that has been linked to a migrtion. - Add accompanying LinkedVersionInterface - Refactor all code and tests to accomodate these changes
- Also refactored a few other of its internal methods.
- Refactored MigrationComparator and NamespacesAwareComparator
gsomoza
force-pushed
the
code-quality
branch
3 times, most recently
from
0d5bf3f
to
3adab27
Compare
…ated classes even more and simplified some of their code.
gsomoza
force-pushed
the
code-quality
branch
from
3adab27
to
709d0a6
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Versioninto two types:Version(with properties "id" & "migrated") andLinkedVersion(extendsVersionand adds the "migration" property).Removed
ComparatorAwareInterface, its trait, its test, and updatedAbstractRepositoryto not use it (the comparator is now a constructor parameter for that class).