Dockerfile: Switch to using base images by arch #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Private DTs do not have base images, so switching to using base images by arch simplifies automated testing for them. We also remove UDEV since it's not needed for this particular application and throws the following warning in the application logs: balena-hello-world Unable to start udev, container must be run in privileged mode to start udev! Change-type: patch Signed-off-by: Alexandru Costache <alexandru@balena.io>
|
@balena-ci I self-certify! |
ghost
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private DTs do not have base images, so switching
to using images by arch simplifies automated
testing for them.
We also remove UDEV since it's not needed
for this particular application and throws
the following warning in the application logs:
balena-hello-world Unable to start udev,
container must be run in privileged mode to start udev!
Change-type: patch
Signed-off-by: Alexandru Costache alexandru@balena.io
Connects-to: balena-os/meta-balena#2678 (comment)