Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitpicks #1

Merged
merged 8 commits into from
Jul 4, 2019
Merged

Nitpicks #1

merged 8 commits into from
Jul 4, 2019

Conversation

zrzka
Copy link
Contributor

@zrzka zrzka commented Jul 4, 2019

  • Reformatted README
    • Nicer and to make MD linter happy
  • Use printf instead of echo
    • Educational, echo is not standardised
  • Python formatting
  • start -> start.sh & Apache License
    • Just to keep consistency over projects

Robert Vojta added 7 commits July 4, 2019 15:58
Reformat README
989b717 
Make it a bit nicer and to make MD linter happy.

Change-type: patch
Signed-off-by: Robert Vojta <robert@balena.io>
Use printf instead of echo
38009c3 
printf is recommended for new applications. /bin/bash doesn’t work on all systems.

Change-type: patch
Signed-off-by: Robert Vojta <robert@balena.io>
Use printf & case instead of multiple ifs
e8c8c96 
Change-type: patch
Signed-off-by: Robert Vojta <robert@balena.io>
Remove unnecessary semicolon
26598eb 
Change-type: patch
Signed-off-by: Robert Vojta <robert@balena.io>
Reformat Python code
4b95fba 
Change-type: patch
Signed-off-by: Robert Vojta <robert@balena.io>
Rename start to start.sh
90390e0 
Change-type: patch
Signed-off-by: Robert Vojta <robert@balena.io>
Add Apache License
3556bba 
Signed-off-by: Robert Vojta <robert@balena.io>
@zrzka zrzka requested a review from chrisys July 4, 2019 14:10
chrisys
chrisys approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@chrisys chrisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input! Much appreciated

@chrisys chrisys merged commit 39d9e7f into master Jul 4, 2019
@chrisys chrisys deleted the nitpicks branch July 4, 2019 15:07
@itsthekraken itsthekraken mentioned this pull request Sep 28, 2020
Closed
@ejannett ejannett mentioned this pull request Oct 29, 2020
Merged
@eiddor eiddor mentioned this pull request Dec 4, 2020
Closed
@arjan5340 arjan5340 mentioned this pull request Dec 26, 2020
Closed
@jcat2 jcat2 mentioned this pull request Jan 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisys chrisys chrisys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zrzka @chrisys