Merge pull request #83 from balena-io-modules/fix-disabled-typing

Adapt isDisabled typing

package.json

@@ -10,7 +10,7 @@
     "README.md"
   ],
   "dependencies": {
-    "@balena/ui-shared-components": "^5.0.0",
+    "@balena/ui-shared-components": "^5.0.8",
     "json-e": "^4.4.3",
     "lodash": "^4.17.21",
     "qs": "^6.10.3",

src/AutoUI/Actions/ActionContent.tsx

@@ -8,7 +8,7 @@ interface ActionContentProps<T> {
 	affectedEntries: T[] | undefined;
 	checkedState: CheckedState | undefined;
 	getDisabledReason: AutoUIAction<T>['isDisabled'];
-	onDisabledReady: (arg: string | undefined) => void;
+	onDisabledReady: (arg: string | null) => void;
 }
 
 // This component sole purpose is to have the useRequest being called exactly once per item,
@@ -23,10 +23,11 @@ export const ActionContent = <T extends {}>({
 }: ActionContentProps<T>) => {
 	useRequest(
 		async () => {
-			const disabled = await getDisabledReason?.({
-				affectedEntries,
-				checkedState,
-			});
+			const disabled =
+				(await getDisabledReason?.({
+					affectedEntries,
+					checkedState,
+				})) ?? null;
 			onDisabledReady(disabled);
 			return disabled;
 		},

src/AutoUI/index.tsx

@@ -314,7 +314,7 @@ export const AutoUI = <T extends AutoUIBaseResource<T>>({
 						);
 					},
 					isDisabled: async ({ affectedEntries, checkedState }) =>
-						getTagsDisabledReason(
+						await getTagsDisabledReason(
 							affectedEntries,
 							tagField as keyof T,
 							checkedState,

src/AutoUI/schemaOps.ts

@@ -79,7 +79,7 @@ export interface AutoUIAction<T> {
 		affectedEntries: T[] | undefined;
 		/** checkState can be undefined only for entity case, since card does not have a selection event  */
 		checkedState: CheckedState | undefined;
-	}) => MaybePromise<string | undefined>;
+	}) => MaybePromise<string | null>;
 	isDangerous?: boolean;
 }
 

src/AutoUI/utils.ts

@@ -103,6 +103,7 @@ export const getTagsDisabledReason = async <T extends AutoUIBaseResource<T>>(
 		// TODO: Pass the resource name instead.
 		return t('info.edit_tag_no_permissions', { resource: 'item' });
 	}
+	return null;
 };
 
 export const getCreateDisabledReason = <T extends AutoUIBaseResource<T>>(