Always call onChange to provide the OData options on mount #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myarmolinsky
reviewed
Dec 7, 2023
src/AutoUI/index.tsx
Outdated
| } | ||
| : undefined)} | ||
| > | ||
| {(data == null || Array.isArray(data)) && ( |
There was a problem hiding this comment.
We already had the Array.isArray(), which we could drop if we drop support for rendering objects in autoUI.
The data == null is necessary for the Filters to be mounted (w/ display: none) even before the initial load of the data, so that they can parse the url (or fallback to defaults) and trigger $setFilters, which triggers onChange, which provides the pine options to the parent component, for it to use them to fetch the data.
Let me leave a comment :)
Change-type: patch
thgreasi
force-pushed
the
callOnChangeOnMount
branch
from
9ab957e
to
228ee67
Compare
|
I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: https://balena.zulipchat.com/#narrow/stream/408336-aspect.2Fuser-experience/topic/'Blank'.20screens.20in.20cloud.20dashboard