Add support for null & not null filter options to enum columns #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch
JSReds
force-pushed
the
add-enum-null-filter
branch
from
0a622e5
to
2b1c014
Compare
added 2 commits
June 20, 2024 12:17
Change-type: minor
Change-type: patch
JSReds
force-pushed
the
add-enum-null-filter
branch
from
2b1c014
to
77ebec0
Compare
JSReds
changed the title
thgreasi
approved these changes
Jun 20, 2024
| parsedFilterDescription: SieveFilterDescription, | ||
| ): string => { | ||
| const { schema, value } = parsedFilterDescription; | ||
| if (schema && isDateTimeFormat(schema.format)) { | ||
| return dateFormat(value, 'PPPppp'); | ||
| } | ||
| if (schema?.enum && 'enumNames' in schema) { | ||
| const index = schema.enum.findIndex((a) => isEqual(a, value)); | ||
| return (schema.enumNames as string[])[index]; |
There was a problem hiding this comment.
I guess we could do v
Suggested change
| return (schema.enumNames as string[])[index]; | |
| return String(schema.enumNames[index]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.