Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should pin @type/lodash to a TS 2.4 compatible version #71

Closed
thgreasi opened this issue Mar 5, 2019 · 0 comments
Closed

Should pin @type/lodash to a TS 2.4 compatible version #71

thgreasi opened this issue Mar 5, 2019 · 0 comments
Assignees
@thgreasi

Comments

@thgreasi
Copy link
Contributor

thgreasi commented Mar 5, 2019 •
edited
Loading

@types/lodash@4.14.122 (dependency of @types/lodash.memoize@4.1.6) which got released yesterday break when used in TS < 2.8.
The current package.json states "typescript": "^2.4.2" and consumer projects can break with the new typings.
This broke the SDKs test cases on master.
We should consider pinning @types/lodash@4.14.121 for which we need to drop lodash.memoize.
@thgreasi thgreasi self-assigned this Mar 5, 2019
@thgreasi thgreasi mentioned this issue Mar 5, 2019
Closed
thgreasi added a commit that referenced this issue Mar 5, 2019
@thgreasi
Limit @types/lodash version to not break TS<2.8 consumers
4dc97c0 
Resolves: #71
Change-type: patch
Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
@thgreasi thgreasi mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thgreasi thgreasi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thgreasi