Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .prerelease() method #18

Merged
merged 2 commits into from
Aug 1, 2017
Merged

Conversation

LucianBuzzo
Copy link
Contributor

change-type: minor

Connects to #17

@LucianBuzzo LucianBuzzo self-assigned this Jul 31, 2017

version = trimOsText(safeSemver(version));

return semver.prerelease(version);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I'm almost annoyed that semver doesn't choke on this, when it does on everything else, but it does at least make this implementation lovely and simple 👍

@resin-io-modules-versionbot
Copy link

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #18. The reason for this is:
Cannot read property 'split' of undefined
Please carry out relevant changes or alert an appropriate admin.

@resin-io-modules-versionbot
Copy link

VersionBot failed to commit a new version to prepare a merge for the above pull request here: #18. The reason for this is:
Cannot read property 'split' of undefined
Please carry out relevant changes or alert an appropriate admin.

Connects to #17

change-type: minor
@resin-io-modules-versionbot
Copy link

VersionBot failed to carry out a status check for the above pull request here: #18. The reason for this is:
Ref not found
Please carry out relevant changes or alert an appropriate admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants