Add .lt() method
#22
Merged
Add .lt() method
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
suggested changes
Jul 31, 2017
src/index.ts
Outdated
| return false; | ||
| } | ||
|
|
||
| return semver.lt(versionA, versionB); |
There was a problem hiding this comment.
See my gte comment: this should at least be defined in terms of gte (e.g. lt(a, b) => !gte(a, b)) even if we do want different behaviour to compare, but more likely everything should just be compare-based, I think.
Connects to #20 change-type: minor
pimterry
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #20
change-type: minor