Normalize range/version used in maxSatisfying method #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimterry
suggested changes
Sep 15, 2017
README.md
Outdated
| @@ -106,140 +106,6 @@ If both values are invalid semver values, then the values are compared alphabeti | |||
| | versionA | <code>string</code> \| <code>null</code> \| <code>undefined</code> | The first version to compare | | |||
| | versionB | <code>string</code> \| <code>null</code> \| <code>undefined</code> | The second version to compare | | |||
|
|
|||
| **Example** | |||
There was a problem hiding this comment.
This appears to have removed all the examples from the README?
test/index.spec.ts
Outdated
| ).to.equal(0); | ||
| expect( | ||
| semver.compare('Resin OS 2.0.0+prod', 'Resin OS 2.0.0 (prod)'), | ||
| ).to.equal(0); |
There was a problem hiding this comment.
I can see why this (and all the other changes in this file) have happened, and prettier is great, but this does make me a little sad. Could we boost the line length, so all these tests are readable (both here and in the docs), or is that not worth it?
There was a problem hiding this comment.
I'm happy to boost the line length here, readability is important for these test files
pimterry
approved these changes
Sep 15, 2017
LucianBuzzo
force-pushed
the
53-maxsat-normalize
branch
from
9d92f2f
to
6e014d0
Compare
Connects to #53 change-type: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #53
change-type: minor