Add travis CI integration #7
Conversation
package.json
Outdated
| "main": "src/index.js", | ||
| "typings": "src/index.d.ts", | ||
| "scripts": { | ||
| "test": "mocha -r ts-node/register --outDir tmp test/index.spec.ts", | ||
| "build": "tsc src/index.ts" | ||
| "build": "tsc src/index.ts", | ||
| "ci": "npm run test" |
There was a problem hiding this comment.
Don't think you need this - if you drop this script, and don't specify a script in .travis.yml at all then it'll run npm test by default anyway.
There was a problem hiding this comment.
I'm adding a lint script in a follow up pr, so the ci script will become npm run lint && npm test.
There was a problem hiding this comment.
Normal developers should run that too though, and normal developers running npm run ci feels weird.
Generally, I'd make npm test the go-to entry point to test everything - it's nice and intuitive and it's what everybody & everything will run by default - and make test run npm run lint && npm run mocha.
There was a problem hiding this comment.
ok cool 👍 I'll drop the ci script
package.json
Outdated
| "chai": "4.1.0", | ||
| "mocha": "3.4.2", | ||
| "ts-node": "3.2.1", | ||
| "typescript": "2.4.2" |
There was a problem hiding this comment.
I don't think we should do this, because there's some downsides, it's inconsistent with most/all our other modules, and there's a better option.
Practically, this is going to mean npm can't dedupe dependencies (i.e. if this depends on semver 5.3.0 and another module uses semver 5.3.1, both will have to be installed and webpack bundled). That's bad for bundle and install sizes, but if you have slightly different behaviour between the two modules it can lead to all sorts of crazy fun bugs where things only break in half your application.
More fluffily, while breaking patch releases are super annoying, it's generally better to enforce any version fixing we need at the top level (i.e. the UI). There we can use something that works recursively, which is more reliable and easier to manage. If we want to fix versions just for development on this module itself here, but not for downstream consumers, we should use npm5 or yarn, which can happily do that.
There was a problem hiding this comment.
(typescript is one exception I think you can probably get away with here, since it's pretty major and I know we've had specific problems there, but for other packages I think this holds)
package.json
Outdated
| @@ -1,27 +1,28 @@ | |||
| { | |||
| "name": "resin-semver", | |||
| "version": "0.1.1", | |||
| "description": "resin specific semver utility methods", | |||
| "description": "Resin.io specific semver utility methods", | |||
| "main": "src/index.js", | |||
| "typings": "src/index.d.ts", | |||
| "scripts": { | |||
| "test": "mocha -r ts-node/register --outDir tmp test/index.spec.ts", | |||
There was a problem hiding this comment.
Why do we need the ourDir here? I think most of our other modules just don't bother.
LucianBuzzo
added
procbots/versionbot/ready-to-merge
and removed
procbots/versionbot/ready-to-merge
labels
Connects to #2 change-type: patch
LucianBuzzo
changed the title
Connects to #2
change-type: patch