Support using memory storage by passing dataDirectory: false #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
force-pushed
the
data-directory-false
branch
from
1b8f7a7
to
106b2ce
Compare
otaviojacobi
approved these changes
Jul 27, 2023
| ): BalenaSettingsStorage => { | ||
| const store = | ||
| options?.dataDirectory === false || !localStore.isSupported() | ||
| ? virtualStore.createStore() |
There was a problem hiding this comment.
Much cleaner to read without passing a dataDirectory to the virtual store, thanks!
Change-type: minor
thgreasi
force-pushed
the
data-directory-false
branch
2 times, most recently
from
07c4e0d
to
c6c29b0
Compare
thgreasi
added a commit
to balena-io-modules/balena-auth
that referenced
this pull request
Jul 28, 2023
Depends-on: balena-io-modules/balena-settings-storage#37 Change-type: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor