Replace error chain #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 15, 2018 15:18
Change-type: patch Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
cyplo
approved these changes
Nov 15, 2018
added 3 commits
November 16, 2018 08:44
Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
Signed-off-by: Robert Vojta <robert@balena.io>
|
lgtm 👍 |
Signed-off-by: Robert Vojta <robert@balena.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
PR contains:
.travis.yml[1] This is ongoing work, because I'd like to add more info to error messages (like the whole expression, etc.), but it's kinda okay for now. It's nothing that should block us - internal stuff, no public API breakage.
Why custom error and not failure for example? error-chain was deprecated and failure recommended. The problem here is that even the failure is not magic & final solution, there's still some ongoing work, ... Also I think that we should use custom error types for libs, which do comply with
std::error::Error. The reason I was using error-chain was simple - speed & experimentation. Now, when things are settling down, there's no reason to use it.