Convert to typescript #54
Conversation
| @@ -0,0 +1,78 @@ | |||
| import { createReadStream, readFileSync } from 'fs'; | |||
There was a problem hiding this comment.
When I joined, Hedley explained that we should add the licence boilerplate at the top of every file we create or modify. If so, a conversion to typescript seems like a good opportunity to do it:
/**
* @license
* Copyright 2019 Balena Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
There was a problem hiding this comment.
And the CI complains about it apparently, so it's certainly something we should do
|
Seems like all the FilterStream stuff has disappeared from |
* replace xml and htmlparser2 with xml-js; * remove nanobench; * remove file open/close from ReadStream; Change-type: major
Change-type: patch
Change-type: patch
|
@lurch docs updated, filter-stream is back |
README.md
Outdated
| @@ -21,13 +21,13 @@ $ npm install --save blockmap | |||
| For detailed API documentation, see [`/doc`](https://github.com/resin-io-modules/blockmap/tree/master/doc). | |||
There was a problem hiding this comment.
I guess the URL here ought to be updated to balena-io-modules ?
|
Looks like there's now unintended duplication between |
Change-type: patch
@lurch updated |
Change-type: patch
|
@resin-ci retest |
|
@zvin Should we remove travis/appveyor actually? I see they fail and block the PR |
Change-type: patch
Change-type: major