Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit supported versions for checks #126

Closed
xginn8 opened this issue Oct 2, 2019 · 5 comments
Closed

Limit supported versions for checks #126

xginn8 opened this issue Oct 2, 2019 · 5 comments
Assignees

Comments

@xginn8
Copy link
Contributor

xginn8 commented Oct 2, 2019

The title was Checks fail on balenaOS 2.3.0 ...with the following error:

Error reported when querying checks data: checks failed: exit code 2 stderr: jq: Unknown option -cn Use jq --help for help with command-line options, or see the jq documentation at http://stedolan.github.com/jq jq: Unknown option -cn Use jq --help for help with command-line options, or see the jq documentation at http://stedolan.github.com/jq jq: Unknown option -cn Use jq --help for help with command-line options, or see the jq documentation at http://stedolan.github.com/jq jq: Unknown option -c

Expanding this a bit, we should decide on what we support for devices going forward, and make this clear.

@xginn8
Copy link
Contributor Author

xginn8 commented Oct 4, 2019

@shaunmulligan & @imrehg what are your thoughts on limiting checks to a certain number of deployed devices? ie, aiming to cover N% of devices. currently, the breakdown is as follows:

50% of devices are greater than v2.31.2
75% of devices are greater than: v2.26.0
90% of devices are greater than: v2.9.7
99% of devices are greater than: v2.0.0
99.9% of devices are greater than: v1.24.1

It may not make sense to reconfigure the check logic to support older OSes, and instead just display a notification that the device is too old (thus feeding back into promoting host OS upgrades). The farthest back I can currently provision is 2.11.0+rev1 on the NUC (even from staging), and I can confirm the checks work on that OS version. Perhaps it makes sense for that to be the initial cutoff? That version would cover roughly ~87.826% of devices currently deployed.

@xginn8
Copy link
Contributor Author

xginn8 commented Oct 4, 2019

Screenshot_2019-10-04  STAGING  balenaCloud silent-fog
I've put together a demo of what this could look like, if it makes sense (just pretend the version is correct in the screenshot)

xginn8 pushed a commit that referenced this issue Oct 8, 2019
Connects-to: #126
Change-type: patch
Signed-off-by: Matthew McGinn <matthew@balena.io>
xginn8 pushed a commit that referenced this issue Oct 8, 2019
Connects-to: #126
Change-type: patch
Signed-off-by: Matthew McGinn <matthew@balena.io>
xginn8 pushed a commit that referenced this issue Oct 9, 2019
Connects-to: #126
Change-type: patch
Signed-off-by: Matthew McGinn <matthew@balena.io>
@xginn8 xginn8 changed the title Checks fail on balenaOS 2.3.0 Limit supported versions for checks Oct 9, 2019
xginn8 pushed a commit that referenced this issue Oct 10, 2019
Connects-to: #126
Change-type: patch
Signed-off-by: Matthew McGinn <matthew@balena.io>
xginn8 pushed a commit that referenced this issue Oct 10, 2019
Connects-to: #126
Change-type: patch
Signed-off-by: Matthew McGinn <matthew@balena.io>
@xginn8
Copy link
Contributor Author

xginn8 commented Nov 26, 2019

In development, we will only test multicontainer-capable devices and above, but will not limit the UI.

@xginn8
Copy link
Contributor Author

xginn8 commented Mar 17, 2020

We can and should display a warning banner in these cases

cc @tmigone

@xginn8 xginn8 reopened this Mar 17, 2020
@xginn8
Copy link
Contributor Author

xginn8 commented May 22, 2020

we now warn in the UI for this condition

@xginn8 xginn8 closed this as completed May 22, 2020
@xginn8 xginn8 self-assigned this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant