Add some type casting so that it compiles on TypeScript 3.5 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: #79 Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>
thgreasi
requested review from
CameronDiver,
dfunckt,
hedss,
LucianBuzzo,
nazrhom,
Page- and
richbayliss
as code owners
thgreasi
commented
Jun 10, 2019
| `'$orderby' objects must have exactly one element, got ${ | ||
| result.length | ||
| } elements`, | ||
| `'$orderby' objects must have exactly one element, got ${result.length} elements`, |
There was a problem hiding this comment.
This change is from the newer prettier version that is now available.
LucianBuzzo
reviewed
Jun 17, 2019
| @@ -897,7 +895,9 @@ abstract class PinejsClientCoreTemplate< | |||
| for (const validParam of validParams) { | |||
| const value = params[validParam]; | |||
| if (value != null) { | |||
| this[validParam] = value; | |||
| (this[validParam] as PinejsClientCoreTemplate< | |||
There was a problem hiding this comment.
Are the parentheses necessary here?
There was a problem hiding this comment.
Yes, otherwise it's a syntax error.
I assume that prettier would have already changed this if it thought that it should.
Page-
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #79
Change-type: patch
Signed-off-by: Thodoris Greasidis thodoris@balena.io