Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prebuild): Fix prebuild double upload #35

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

jhermsmeier
Copy link
Contributor

@jhermsmeier jhermsmeier commented Jul 10, 2018

Electron 1.8.x and 2.0.x have the same module ABI (v57),
causing the uploads to conflict and become reserved, yet not complete,
in turn causing further uploads and downloads to fail for that prebuild.

Change-Type: patch
See also: prebuild/prebuild#221

Electron 1.8.x and 2.0.x have the same module ABI (v57),
causing the uploads to conflict and become reserved, yet not complete,
in turn causing further uploads and downloads to fail for that prebuild.

Change-Type: patch
@jhermsmeier jhermsmeier requested review from zvin and jviotti July 10, 2018 19:48
@lurch
Copy link

lurch commented Jul 10, 2018

It took a really frustrating amount of searching to find (why is this not commonly published knowledge??) but I eventually found https://github.com/lgeiger/node-abi/blob/master/index.js#L51 which was the only "definitive reference" I could find. (Unless I was using entirely the wrong search-terms of course)

@jhermsmeier
Copy link
Contributor Author

@lurch The modules versions <=> node version mapping is also documented on https://nodejs.org/en/download/releases/ – iirc it's tied to v8's breaking API changes, so it's a bit opaque. Another place you can also check it, is through process.versions;

$ node
> process.versions
{ http_parser: '2.8.0',
  node: '6.14.3',
  v8: '5.1.281.111',
  uv: '1.16.1',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  icu: '58.2',
  modules: '48',
  napi: '3',
  openssl: '1.0.2o' }

@lurch
Copy link

lurch commented Jul 11, 2018

The modules versions <=> node version mapping is also documented on https://nodejs.org/en/download/releases/

Ah, so it is! Shame that it doesn't also cover Electron though (which my link did 😉 )

Another place you can also check it, is through process.versions;

Yeah, I found that documented, but that obviously only tells you the module ABI of your currently-running version, not of all versions 🙂

@jhermsmeier jhermsmeier merged commit fef4824 into master Jul 11, 2018
@jhermsmeier jhermsmeier deleted the fix-prebuild-double-upload branch July 11, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants