Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS download always downloads prod images #688

Closed
pimterry opened this issue Oct 17, 2017 · 1 comment
Closed

OS download always downloads prod images #688

pimterry opened this issue Oct 17, 2017 · 1 comment
Labels
type:bug

Comments

@pimterry
Copy link
Contributor

Due to balena-io/balena-sdk#422, even explicitly selecting a dev image will download a prod version (and lie to you in the progress bar), as our version comparison considers them interchangeable, following to the semver spec, so arbitrarily chooses the alphabetically latest (prod).
@pimterry pimterry mentioned this issue Oct 17, 2017
Merged
pimterry added a commit that referenced this issue Oct 17, 2017
@pimterry
Fix issue where os download would always download prod images
0e4c6c4 
This also adds support for submodules using resin-sdk shared options
rather than resin-sdk-preconfigured.

Change-Type: patch
Connects-To: #688
@pimterry pimterry mentioned this issue Oct 17, 2017
Merged
@pimterry
Copy link
Contributor Author

Fixed in CLI version 6.6.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pimterry