Fix left-overs from balena-sdk v13 bump #1742

thgreasi · 2020-04-21T16:27:04Z

Connects-to: #1770 (meta v12 release issue)
Change-type: patch
See: balena-io/open-balena-api#338
See: https://www.flowdock.com/app/rulemotion/i-cli/threads/0Mu_15537VAJ1wxbElpROBA-g5Y
Signed-off-by: Thodoris Greasidis thodoris@balena.io

Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.

If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.

Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

thgreasi · 2020-04-21T16:33:09Z

lib/actions/device.coffee

+			)
+			# TODO: combine with the above query once the overall_status field
+			# is moved to open-balena-api
+			balena.models.device.get(params.uuid, { $select: 'overall_status' }).get('overall_status').catchReturn(null)


I opened the PR just in case that the CLI needs to catch-up with any newer SDK feature before the open-balena-api adds this computed field.
On principle this shouldn't be a blocker for this PR. Moreover the older balenaDeviceStatus implementation wasn't working properly (as I just found out) since not all the required fields were provided.

Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

pdcastro · 2020-04-21T21:15:45Z

INSTALL.md

@@ -93,7 +93,7 @@ If you are a Node.js developer, you may wish to install the balena CLI via [npm]
 The npm installation involves building native (platform-specific) binary modules, which require
 some additional development tools to be installed first:

-* [Node.js](https://nodejs.org/) version 8, 10 or 12
+* [Node.js](https://nodejs.org/) version 10 or 12


I see you've labeled this PR change-type: major, resulting in CLI v12.0.0. We've been collecting breaking changes for v12 in this GDoc: https://docs.google.com/document/d/1uHE-_LLu5gJUQZICQJtlo76EQCm90z0CMAwpkfw6s8w/edit

@srlowe, I think pressure is building to release CLI v12... Node v8 is no longer supported, Node 14 is around the corner, Page wanted to take advantage of Node 10+ features, we need to upgrade balena-sdk too, including testing. I wanted to include issue #1032 in v12, but each week there are new hurdles (the latest being balena CI being unhappy with the MIT licence in the migration from zeit/dockerignore to balena-io-modules/dockerignore). Anyway, we need to put some effort into that GDoc and CLI v12, perhaps with a pause in the oclif/typescript conversion. Maybe something we could also discuss with @odyslam on Thursday's call.

@pdcastro is there a v12 release branch that you PR against?
Also heads up that there is a pending arch call item wrt whether we should be using release branches at all or not, so it would be great if you could be there as well.

No release branch yet. My thinking is that, when possible, we should release the "breaking changes" behind flags (command-line options) that enable the new behaviour in the current major release. This is possible, for example, for the new gitignore / dockerignore behaviour (but probably not possible for Node 8 → Node 14 support). In this case, it is not really a breaking change, and it also allows users to try the new feature before upgrading the CLI to the next major version. Then, when all this work is done and already released, a release branch is created for the shortest amount of time possible, and what it does is to change the "default behaviour" (without the enabling flags) to be same as the behaviour with the enabling flags, and the enabling flags become a no-op (redundant). I'll look out for the arch call, thanks for the hint! 👍

Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

pdcastro · 2020-04-24T11:33:23Z

package.json

@@ -74,7 +74,7 @@
  "author": "Juan Cruz Viotti <juan@balena.io>",
  "license": "Apache-2.0",
  "engines": {
-    "node": ">=8.0"
+    "node": ">=10.0"


@thgreasi, as discussed in Google chat (balena-io/product), would it be possible to avoid this Node.js bump in this PR, and have this PR's change-type be minor or patch rather than major? And then we merge this PR in CLI v11, and I can add the "balenaCloud backend support/deprecation policy" to the CLI.

@pdcastro you mean, even though the SDK's package.json declares that the minimum supported node version is v10?
I haven't tried it, but I think that while doing a fresh npm install on node 8, npm will complain as soon as it sees that the sdk needs node 10.

thgreasi · 2020-05-27T16:50:58Z

Connects-to: #1770

Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

Change-type: patch

Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

This allows unauthenticated users to download unconfigured images. Balena-pine v11 that started being user by balena-sdk v13 now support unauthenticated requests. Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

thgreasi self-assigned this Apr 21, 2020

thgreasi changed the title ~~Update balena sdk 13.2.2~~ Update balena-sdk to v13.2.2 Apr 21, 2020

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from 605a450 to d5ab070 Compare April 21, 2020 16:28

thgreasi mentioned this pull request Apr 21, 2020

os download: Allow not logged in users to download images #1743

Merged

thgreasi added a commit that referenced this pull request Apr 21, 2020

os download: Allow not logged in users to download images

deab11c

Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

thgreasi commented Apr 21, 2020

View reviewed changes

thgreasi added a commit that referenced this pull request Apr 21, 2020

os download: Allow not logged in users to download images

10159da

Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from d5ab070 to 467324e Compare April 21, 2020 16:40

pdcastro reviewed Apr 21, 2020

View reviewed changes

thgreasi added a commit that referenced this pull request Apr 24, 2020

os download: Allow not logged in users to download images

0dd0500

Change-type: minor See: #1742 Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from 467324e to 70fe7eb Compare April 24, 2020 10:10

pdcastro reviewed Apr 24, 2020

View reviewed changes

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from 70fe7eb to fb40860 Compare April 29, 2020 12:02

pdcastro mentioned this pull request May 27, 2020

Release new major version (feature list) #1770

Closed

14 tasks

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from fb40860 to e901e76 Compare June 29, 2020 13:00

thgreasi changed the title ~~Update balena-sdk to v13.2.2~~ Fix left-overs from balena-sdk v13 bump Jun 29, 2020

thgreasi requested a review from pdcastro June 29, 2020 13:09

thgreasi marked this pull request as ready for review June 29, 2020 13:09

thgreasi requested review from CameronDiver and srlowe as code owners June 29, 2020 13:09

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from e901e76 to 2229f41 Compare June 29, 2020 13:20

pdcastro approved these changes Jun 29, 2020

View reviewed changes

thgreasi added 3 commits June 29, 2020 22:55

Stop using the removed imageMakerUrl balena-sdk argument

bd4d836

Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

Drop balena-device-status from the dependencies

45f131e

Change-type: patch

Prepare for field based retrieval of device overall_status

3207a29

Change-type: patch Signed-off-by: Thodoris Greasidis <thodoris@balena.io>

balena-ci force-pushed the update-balena-sdk-13.0.0 branch from 2229f41 to 8ed4da4 Compare June 29, 2020 19:55

thgreasi force-pushed the update-balena-sdk-13.0.0 branch from 8ed4da4 to 3207a29 Compare June 29, 2020 19:56

ghost merged commit d681dac into master Jun 29, 2020

ghost deleted the update-balena-sdk-13.0.0 branch June 29, 2020 20:52

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix left-overs from balena-sdk v13 bump #1742

Fix left-overs from balena-sdk v13 bump #1742

thgreasi commented Apr 21, 2020 •

edited

thgreasi Apr 21, 2020 •

edited

pdcastro Apr 21, 2020

thgreasi Apr 22, 2020

pdcastro Apr 22, 2020

pdcastro Apr 24, 2020

thgreasi Apr 24, 2020

thgreasi commented May 27, 2020

Fix left-overs from balena-sdk v13 bump #1742

Fix left-overs from balena-sdk v13 bump #1742

Conversation

thgreasi commented Apr 21, 2020 • edited

thgreasi Apr 21, 2020 • edited

Choose a reason for hiding this comment

pdcastro Apr 21, 2020

Choose a reason for hiding this comment

thgreasi Apr 22, 2020

Choose a reason for hiding this comment

pdcastro Apr 22, 2020

Choose a reason for hiding this comment

pdcastro Apr 24, 2020

Choose a reason for hiding this comment

thgreasi Apr 24, 2020

Choose a reason for hiding this comment

thgreasi commented May 27, 2020

thgreasi commented Apr 21, 2020 •

edited

thgreasi Apr 21, 2020 •

edited