Document Python native build dependency #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Type: patch
zvin
approved these changes
Jun 12, 2018
|
@pimterry, status checks have failed for this PR. Please make appropriate changes and recommit. |
thgreasi
approved these changes
Jun 12, 2018
| @@ -79,7 +79,7 @@ | |||
| "gulp-shell": "^0.5.2", | |||
| "mochainon": "^2.0.0", | |||
| "pkg": "^4.3.0-beta.1", | |||
| "prettier": "^1.9.2", | |||
| "prettier": "1.13.5", | |||
There was a problem hiding this comment.
I'd rather not - they do style changes in patch releases. The change that this fix is for came out in 1.13.5.
ghost
merged commit 
ghost
removed
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #888 (caused by using Python 3, instead of 2.7)
I'm also adding a recommendation for the standalone mode here, since that's now reasonably stable, and likely to be the easier option for most users here, rather than fighting native build environments.
Change-Type: patch