Replace generateApiKey with generateProvisioningKey #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Type: major
pimterry
force-pushed
the
remove-generate-api-key
branch
from
60b2a8d
to
c67d8d0
Compare
thgreasi
approved these changes
Oct 3, 2017
| resin.models.application.getApiKey(@application.app_name).then (apiKey) -> | ||
| m.chai.expect(_.isString(apiKey)).to.be.true | ||
| m.chai.expect(apiKey).to.have.length(32) | ||
| it 'should be able to generate an provisioning key by name', -> |
There was a problem hiding this comment.
Is "a provisioning key" better?
There was a problem hiding this comment.
Damn, good spot. Fixed.
…ateProvisioningKey We now no longer allow generating app wide keys. Generate a provisioning key to register new devices, and look at JWTs or user API keys (coming soon) for other uses. Change-Type: major
pimterry
force-pushed
the
remove-generate-api-key
branch
from
c67d8d0
to
3bafe78
Compare
|
I'm going to wait for @Page- to confirm before I merge this, just because I'm not confident my understanding of the provisioning key work is totally correct. |
Page-
approved these changes
Oct 3, 2017
pimterry
added a commit
that referenced
this pull request
Oct 11, 2017
Replace generateApiKey with generateProvisioningKey
pimterry
added a commit
that referenced
this pull request
Oct 12, 2017
Replace generateApiKey with generateProvisioningKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already deprecated in the API, and we really shouldn't be using or exposing it here. This replaces it with provisioning keys, which are the modern alternative.
This is another fun breaking change, so another inclusion for big lovely v7.