fix: Rework delete-then-download handling in state engine #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
CameronDiver
force-pushed
the
841-delete-then-download
branch
from
250e06e
to
2802c8b
Compare
zvin
approved these changes
Feb 5, 2019
src/application-manager.coffee
Outdated
| @@ -841,7 +841,10 @@ module.exports = class ApplicationManager extends EventEmitter | |||
| return @bestDeltaSource(image, available) | |||
| proxyvisorImages = @proxyvisor.imagesInUse(current, target) | |||
|
|
|||
| imagesToRemove = _.filter availableAndUnused, (image) -> | |||
| potentialDeleteThenDownload = _.filter current.local.apps.services, (svc) -> | |||
| return svc.config.labels['io.balena.update.strategy'] == 'delete-then-download' and svc.status in ['Stopped'] | |||
There was a problem hiding this comment.
Ah, I was actually testing against ['Stopping', 'Stopped'] then I realised this was wrong, and forgot to change. Good catch!
CameronDiver
force-pushed
the
841-delete-then-download
branch
2 times, most recently
from
1c4c505
to
e9b51bb
Compare
In the original implementation it was possible that the delete did not wait for the kill step to be finished, so it would not be deleted. We seperate this process into two steps, to allow for the container to have stopped before proceeding. Change-type: patch Closes: #841 Signed-off-by: Cameron Diver <cameron@balena.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original implementation it was possible that the delete did not
wait for the kill step to be finished, so it would not be deleted.
We seperate this process into two steps, to allow for the container to
have stopped before proceeding.
Change-type: patch
Closes: #841
Signed-off-by: Cameron Diver cameron@balena.io